Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

Update Lexer.php #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Lexer.php #88

wants to merge 1 commit into from

Conversation

flip111
Copy link

@flip111 flip111 commented Oct 18, 2018

improve error handling avoid undescriptive php warning

@flip111
Update Lexer.php
ee15300 
improve error handling avoid undescriptive php warning
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling ee15300 on flip111:patch-1 into c620f44 on hoaproject:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling ee15300 on flip111:patch-1 into c620f44 on hoaproject:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling ee15300 on flip111:patch-1 into c620f44 on hoaproject:master.

@unkind unkind mentioned this pull request Nov 7, 2018
Closed
@Hywan Hywan self-assigned this Nov 12, 2018
@Hywan
Copy link
Member

Hywan commented Feb 19, 2019

Can you explain how to reproduce the warning please?

@flip111
Copy link
Author

flip111 commented Feb 19, 2019

Put a token with an invalid regex. Maybe try [\d, i don't remember exactly what token i had on hand at the time

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Hywan Hywan

Labels
bug difficulty: medium in progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flip111 @coveralls @Hywan