Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GJ v4 #68

Closed
wants to merge 1 commit into from
Closed

Support GJ v4 #68

wants to merge 1 commit into from

Conversation

morgoth
Copy link
Contributor

@morgoth morgoth commented Jul 16, 2024

@mrrooijen
Copy link
Member

Thanks, @morgoth (and @bensheldon for the additional information)!

I don’t have time to look into it this week, but I’ll hopefully get to it next week. At first glance, the changes look good, but I’ll have to update the test suite to verify. I’ll get back to you once I get to it.

@mrrooijen
Copy link
Member

@morgoth I've pushed hirefire-resource 1.0.4 which includes the following changes:

  • Support for good_job ~> 4
  • Use performed_at instead of finished_at to mimic Sidekiq macro latency behavior

Diff: https://github.com/hirefire/hirefire-resource-ruby/compare/v1.0.3..v1.0.4

Thanks for your input!

@mrrooijen mrrooijen closed this Jul 26, 2024
@morgoth morgoth deleted the gj-4 branch July 26, 2024 11:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants