GatewayBot takes custom cache impl as constructor arg #977
Conversation
| @@ -341,7 +342,7 @@ def __init__( | |||
|
|
|||
| # Caching | |||
| cache_settings = cache_settings if cache_settings is not None else config.CacheSettings() | |||
| self._cache = cache_impl.CacheImpl(self, cache_settings) | |||
| self._cache = cache or cache_impl.CacheImpl(self, cache_settings) | |||
There was a problem hiding this comment.
How are you meant to pass a separate cache impl to the bot's init if you're going to need the bot instance to initiate most custom cache impls (esp any which extend the standard impl)
There was a problem hiding this comment.
Oh yeah I forgot about that. Let me change that up on my next commit
|
Closing since it's been decided that this feature is not needed/viable at the moment |
|
Some extra discussion around this can be found at https://canary.discord.com/channels/574921006817476608/644130410564943873/935018943775653958 if you have access to the contributor's discussion |
|
For ref I'm not sure this will be done but i'm leaving the issue and pr open for now for conversation around this idea |
|
Gonna close this for now as I don't see this being implemented properly in the forceable future |
Summary
Added an optional constructor arg to
hikari.GatewayBotwhich takes acache.MutableCacheinstance. If provided, the _cache property is set to that value, or else it uses the default hikari cache implementationChecklist
noxand all the pipelines have passed.Related issues