Prevent referenced messages from replacing cached messages #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norinorin
force-pushed
the
fix/message-reference
branch
from
739f5a8 to
6115b39
Compare
norinorin
commented
Jan 1, 2022
| ) or self._referenced_messages.get(message.referenced_message.id): | ||
| # treat referenced messages as partial | ||
| # so it shouldn't replace the full message if cached. | ||
| referenced_message.object.update(message.referenced_message) |
There was a problem hiding this comment.
I'm unsure if updating it is really needed.
norinorin
force-pushed
the
fix/message-reference
branch
from
6115b39 to
d50707d
Compare
|
Not sure if I like it; will look for other possible solutions. |
norinorin
force-pushed
the
fix/message-reference
branch
from
d50707d to
cf3449c
Compare
|
Closing as I'll leave it stale otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
noxand all the pipelines have passed.Related issues
Closes #904