Fix reference messages not being fully deleted #910
Conversation
davfsa
force-pushed
the
task/fix-memory-leak
branch
from
04d24b2 to
9560ff5
Compare
| referenced_message = message.object.referenced_message | ||
| if not referenced_message and message.object.message_reference and message.object.message_reference.id: | ||
| msg_id = message.object.message_reference.id | ||
| referenced_message = self._message_entries.get(msg_id) or self._referenced_messages.get(msg_id) |
There was a problem hiding this comment.
Are you sure this actually fixes the issue, if a referenced message is cached when message.referenced_message is None then wouldn't that infer there's a case the update/set logic isn't accounting for (possibly to do with idk something funky like the referenced message being deleted and that not cascading to places where its being referenced (to give a random example)).
There was a problem hiding this comment.
I'm not aware if there are any other cases, but another way that I could think of to handle this particular case is to ensure that we're not overriding referenced_message's referenced_message since Discord gives us None.
| if not referenced_message and message.object.message_reference and message.object.message_reference.id: | ||
| msg_id = message.object.message_reference.id | ||
| referenced_message = self._message_entries.get(msg_id) or self._referenced_messages.get(msg_id) | ||
|
|
There was a problem hiding this comment.
Also you're not accounting for what kind of reference this is so for stuff like cross posts, channel follows, and pins adds where you'd have message_reference.id but not referenced_message so this could lead to other edge case bugs but i'm not bothered to check how this'd play out in those scenarios rn
|
Closed to let @norinorin re-open with their changes |
Pull request was closed
Thanks to @norinorin for finding the bug and providing the patch!
The patch was submitted with explicit permission from them
Checklist
noxand all the pipelines have passed.Related issues
Closes #904