connected sockets can be passed to the library #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes hierynomus#924 Signed-off-by: Martin Volf <[email protected]>
hierynomus
approved these changes
Jan 22, 2024
Signed-off-by: Martin Volf <[email protected]>
hierynomus
approved these changes
Jan 26, 2024
Signed-off-by: Martin Volf <[email protected]>
|
one more attempt at actually improving test coverage |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #925 +/- ##
============================================
+ Coverage 68.96% 69.05% +0.08%
- Complexity 1448 1452 +4
============================================
Files 208 208
Lines 7602 7604 +2
Branches 658 660 +2
============================================
+ Hits 5243 5251 +8
+ Misses 2009 2003 -6
Partials 350 350 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client should be able to accept sockets that have been already connected to a remote server.