known_hosts parsing does not ignore malformed base64 strings since 0.36 #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #922 +/- ##
============================================
- Coverage 69.10% 68.91% -0.19%
+ Complexity 1449 1446 -3
============================================
Files 208 208
Lines 7602 7602
Branches 658 658
============================================
- Hits 5253 5239 -14
- Misses 2002 2012 +10
- Partials 347 351 +4 ☔ View full report in Codecov by Sentry. |
vladimirlagunov
pushed a commit
to vladimirlagunov/sshj
that referenced
this pull request
Apr 4, 2024
…36.0 (hierynomus#922) (cherry picked from commit 03f8b22)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous Base64 implementation threw IOExceptions in some places that are now IllegalArgumentExecptions. Both are now caught and logged. OpenSSH ignores this, too.