Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #902. #903

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fix #902. #903

merged 2 commits into from
Nov 21, 2023

Conversation

dkocher
Copy link
Contributor

@dkocher dkocher commented Oct 12, 2023

Resolves #902.

@dkocher dkocher requested a review from hierynomus as a code owner October 12, 2023 09:35
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Merging #903 (8a0e27d) into master (b7dc869) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #903      +/-   ##
============================================
+ Coverage     68.61%   68.78%   +0.16%     
- Complexity     1409     1412       +3     
============================================
  Files           207      207              
  Lines          7504     7505       +1     
  Branches        642      642              
============================================
+ Hits           5149     5162      +13     
+ Misses         2012     1999      -13     
- Partials        343      344       +1     
Files Coverage Δ
...sshj/transport/verification/OpenSSHKnownHosts.java 62.43% <100.00%> (+5.80%) ⬆️

... and 1 file with indirect coverage changes

@hierynomus
Copy link
Owner

Thanks @dkocher Can you add a test for the failure, so that it does not regress again?

@dkocher
Copy link
Contributor Author

dkocher commented Oct 16, 2023

Thanks @dkocher Can you add a test for the failure, so that it does not regress again?

Is there an existing test working with host keys that I could copy from?

@hierynomus
Copy link
Owner

#906 contains the JUnit5 version of the OpenSSHKnownHosts tests... Would those work? I'll merge these once the pipeline succeeds, then you can rebase this one and add the testcases

@hierynomus hierynomus merged commit 50c753d into hierynomus:master Nov 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression writing known host entry key string
3 participants