Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String clustering tests #1201

Open
wants to merge 6 commits into
base: develop-21.11
Choose a base branch
from

Conversation

joseangelhernao
Copy link
Collaborator

No description provided.

Copy link
Member

@luis11011 luis11011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from this tests files I think it's a good idea to include one or two more tests in a classic test file to test the replace:

clusters = df.string_clustering(...)
df.cols.replace(clusters)

Pull the latest changes from develop to fix some of the tests that are not generating.

from optimus.tests.creator import TestCreator, default_configs

op = Optimus("pandas")
df = op.create.dataframe({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should include at least one column with similar strings to properly test this functions.

@joseangelhernao joseangelhernao changed the base branch from develop-21.9 to develop-21.11 December 6, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants