windows: implement tick, call core.initWindow, various fixes
#1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
foxnne
commented
Dec 1, 2024
foxnne
commented
- By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
slimsag
reviewed
Dec 1, 2024
| @@ -266,6 +265,7 @@ pub fn main(core: *Core, core_mod: mach.Mod(Core)) !void { | |||
| // The user wants mach.Core to take control of the main loop. | |||
| if (supports_non_blocking) { | |||
| while (core.state != .exited) { | |||
| try Platform.tick(core); | |||
There was a problem hiding this comment.
Nice, this is probably the fix you needed for Linux @joshua-holmes to get the Linux.zig implementation to have a place to poll for events
There was a problem hiding this comment.
Merging this PR now because of this change.
slimsag
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.