obj: Move Platform and InitOptions fields into core.windows
#1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s`, initial push, only triangle example working on macos currently
slimsag
reviewed
Nov 30, 2024
slimsag
reviewed
Nov 30, 2024
slimsag
reviewed
Nov 30, 2024
slimsag
reviewed
Nov 30, 2024
slimsag
reviewed
Nov 30, 2024
slimsag
reviewed
Nov 30, 2024
slimsag
reviewed
Nov 30, 2024
…als, comment revisions, `device` is no longer optional, `native` is optional
…ctions now send window id
slimsag
reviewed
Nov 30, 2024
slimsag
reviewed
Nov 30, 2024
|
|
||
| // GPU | ||
| // When device is not null, the rest of the fields have been | ||
| // initialized. |
There was a problem hiding this comment.
comment needs updating (device cannot be null)
slimsag
reviewed
Nov 30, 2024
slimsag
reviewed
Nov 30, 2024
slimsag
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is stacked on top of #1308, so review that one first.
At the moment, this PR breaks a lot and only triangle example on macOS is building. The effort here is to move more of Core to use the object system, first of these efforts is to treat windows as a list of objects so all window-dependent fields have been moved to
core.windowsandPlatform.tickjust checks for field changes and responds accordingly.