Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysgpu: replace deprecated @fence builtin #1285

Closed

Conversation

joshua-holmes
Copy link
Contributor

@joshua-holmes joshua-holmes commented Oct 16, 2024

Wrench is trying to update Zig, but Zig had an update that introduced a breaking change:
ziglang/zig#21585

Due to this change, I have removed @fence(). I am new to atomics, but I believe the removal of @fence() means that we need to ensure that everything after the atomic write, which happens in @atomicRmw(), actually happens after the write, not before - namely the deinitialization of parent. This can be done by changing the ordering of @atomicRmw() from .release to .acq_rel, which is what I have done.

  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

@joshua-holmes joshua-holmes marked this pull request as ready for review October 16, 2024 00:50
@joshua-holmes joshua-holmes deleted the fix-wrench branch November 17, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant