sysgpu: replace deprecated @fence builtin #1285
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrench is trying to update Zig, but Zig had an update that introduced a breaking change:
ziglang/zig#21585
Due to this change, I have removed
@fence()
. I am new to atomics, but I believe the removal of@fence()
means that we need to ensure that everything after the atomic write, which happens in@atomicRmw()
, actually happens after the write, not before - namely the deinitialization ofparent
. This can be done by changing the ordering of@atomicRmw()
from.release
to.acq_rel
, which is what I have done.