Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: linux support for Zig 2024.10.0-mach #1280

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

joshua-holmes
Copy link
Contributor

I have verified that none of the type casting will be performed on values that are out of range of the destination. The values are all known at compile time and are very low (less than 10).

  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

I have verified that none of the type casting will be performed on values that are out of range of the destination. The values are all known at compile time and are very low (less than 10).
@joshua-holmes
Copy link
Contributor Author

What needs to happen next is to resolve this linking issue:

[josh@archy mach]$ zig build
install
└─ install mach-sysgpu
   └─ zig build-lib mach-sysgpu Debug native failure
error: the linker needs one or more objects to link
Build Summary: 45/48 steps succeeded; 1 failed
install transitive failure
└─ install mach-sysgpu transitive failure
   └─ zig build-lib mach-sysgpu Debug native failure
error: the following build command failed with exit code 1:
/home/josh/dev/open-source/mach/.zig-cache/o/be7d4b18662045916564ecf64e246c02/build /home/josh/zig/0.14.0-dev.1710+8ee52f99c/files/zig /home/josh/zig/0.14.0-dev.1710+8ee52f99c/files/lib /ho
me/josh/dev/open-source/mach /home/josh/dev/open-source/mach/.zig-cache /home/josh/.cache/zig --seed 0xf5b23bf6 -Zad2156f05b8f8617

This is also seen when compiling for windows (discord message).

@emidoots emidoots changed the title all: linux support for zig 0.14 upgrade all: linux support for Zig 2024.10.0-mach Oct 9, 2024
Copy link
Member

@emidoots emidoots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and interesting to see we have a linker failure on windows too.. that one I think will be easier to fix.

@emidoots emidoots marked this pull request as ready for review October 9, 2024 05:08
@emidoots emidoots merged commit 5957dd5 into hexops:main Oct 9, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants