Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use mlugg/setup-zig #1215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CI: use mlugg/setup-zig #1215

wants to merge 1 commit into from

Conversation

mlugg
Copy link
Contributor

@mlugg mlugg commented Jun 9, 2024

This doesn't need to be merged if you'd prefer to stick with the current logic; I largely just wanted to see if it works properly. Nonetheless, I think this represents an improvement to the CI scripts.

This PR begins using the https://github.com/mlugg/setup-zig action to install Zig in the CI workflow. This has the following advantages:

  • No more target-specific scripts; setting up Zig is 4 simple lines.
  • The tarball's minisig is verified, so this will flag up issues if the Mach mirror ever starts doing anything weird.
  • The Zig version is specified in Mach lingo, i.e. 2024.5.0-mach rather than zig-0.13.0-dev.351+64ef45eb0.
    • This could alternatively say mach-latest, but I figured this makes more sense for handling the upgrade process when new versions are nominated.
  • The global Zig cache is automatically preserved across runs, avoiding redundant work. In particular, this will avoid doing redundant work rebuilding C dependencies on every commit.
  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

@mlugg mlugg force-pushed the ci-mlugg-action branch from 722b690 to 039a3fe Compare June 9, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant