math: Rewrite Vec tests and fix Vec cross calculation bug #1028
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote the old commented out tests in accordance to the Mach style guide and added the listed missing basic tests.
While doing so I also caught two bugs in the cross and swizzling methods:
yzw
instead ofyzx
, and.w()
instead of.x()
, while cross was callingyzx
.mul(b.xzy())
instead of.mul(&b.xzy())