Allow chanlist_minusers to be 0 to show empty channels #2064
Conversation
Allow chanlist_minusers to be 0 to show empty channels
| @@ -310,8 +310,8 @@ chanlist_do_refresh (server *serv) | |||
| else | |||
| { | |||
| /* download all, filter minusers locally only */ | |||
| serv->p_list_channels (serv, "", 1); | |||
| serv->gui->chanlist_minusers_downloaded = 1; | |||
| serv->p_list_channels (serv, "", 0); | |||
There was a problem hiding this comment.
The idea seems fine but I'm not sure about this line. I never want us to actually request that many potential channels unless the user explicitly does so.
There was a problem hiding this comment.
That's fine. My IRC network is some kind of bridged network, so it works for me, but I understand it probably won't work for real IRC networks with tons of channels.
| @@ -727,7 +727,7 @@ chanlist_opengui (server *serv, int do_refresh) | |||
|
|
|||
| if (!serv->gui->chanlist_minusers) | |||
There was a problem hiding this comment.
0 is a valid value for this now.
There might be more places this assumption is made too.
|
@TingPing Sorry to bother you, but after compiling (I am really noob at it, I just edited the files and then ran build in VS) Ctrl+W shortcut does not work. It worked until that change. Any idea why? |
That shortcut was disabled months ago, you can add a custom one in Settings > Keyboard Shortcuts that calls |
Hello,
I think it should be allowed to show channels with 0 users in /list. I tried to make this change and it is working for me, but I think it could be in the official release too.