Make MCL_STATIC_LIB completely static #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently MCL_STATIC_LIB will produce static mcl::mclbn{N} targets, but
these static targets still link to the *non*-static mcl::mcl and so you
end up with a half-static result that still depends on a dynamic lib.
This fixes it to link to the mcl_st static target when MCL_STATIC_LIB is
enabled.
|
Thank you for your contribution. I'll merge it with the main branch later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
MCL_STATIC_LIBoption will produce static mcl::mclbn{N} targets, but these static targets still link to the non-static mcl::mcl and so you end up with a half-static result that still depends on a dynamic lib.This fixes it to link to the mcl::mcl_st static target when MCL_STATIC_LIB is enabled (and mcl::mcl otherwise).