This repository has been archived by the owner on May 1, 2024. It is now read-only.
Fix: Prevent Override of Existing innerCustomChildren #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the check references `customChildren`but the insert is against `customInnerChildren`, this plugin overrides elements inserted by other plugins via `customInnerChildren`. These edits fix that by updating the `existingChildren` check to inspect the correct array of elements.
j-f1
added a commit
to j-f1/forked-hyper-statusline
that referenced
this pull request
Sep 3, 2018
|
I’ve published this to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
existingChildrencheck referencescustomChildrenbut the render uses the
customInnerChildrenproperty, this pluginresets
customInnerChildren, overriding previous children, therebypreventing other extensions from rendering. Fixing the check to
inspect
customInnerChildrenallows this extension to co-exist withother extensions leveraging the
customInnerChildrenproperty.