bump oras minor version #12998
Open
bump oras minor version #12998
+21
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Abro <[email protected]>
pull-request-size
bot
added
the
size/M
Signed-off-by: Austin Abro <[email protected]>
sabre1041
approved these changes
May 12, 2024
Signed-off-by: Austin Abro <[email protected]>
|
@sabre1041 done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a minor update to the oras version while we wait for the major oras v2 upgrade. This update matters because the current auth mechanism in oras breaks when logging into an insecure repo unless an IP address is used. Oras v1.2.5 updates to use docker v25.0.1 for auth mechanisms which avoids this issue
Special notes for your reviewer:
I can give the whole stack trace is wanted, but ultimately it boils down ORAS v1.2.4 calling functions which eventually use this faulty regex to determine if the domain is correct https://github.com/distribution/distribution/blob/v2.8.3/reference/regexp_deprecated.go#L12-L23
If applicable: