build CKEditor5 #57
build CKEditor5 #57
Conversation
|
|
||
| file_uploader = kwargs.get('file_uploader', current_app.config['CKEDITOR_FILE_UPLOADER']) | ||
|
|
||
| if file_uploader != '': |
There was a problem hiding this comment.
Why not something like if not file_uploader instead of if file_uploader != '' ?
There was a problem hiding this comment.
By the way, nice work, @WebberMao
There was a problem hiding this comment.
I following the coding style of the previous version ( as you can see in line 80 ), and if file_uploder is more correct.
Thanks!
|
Hi @WebberMao! Super excited to learn CKEditor5 might be available soon! Any news on the merge? Also: Does it make sense to add GitHub sponsors to this project? |
| c = kwargs.pop('class', '') or kwargs.pop('class_', '') | ||
| kwargs['class'] = u'%s %s' % ('ckeditor', c) |
There was a problem hiding this comment.
Why remove these lines? It supports adding the user-defined class to the textarea element.
| c = kwargs.pop('class', '') or kwargs.pop('class_', '') | ||
| kwargs['class'] = u'%s %s' % ('ckeditor', c) | ||
| return super(CKEditor, self).__call__(field, **kwargs) | ||
| ckeditor=field.name+'_' |
There was a problem hiding this comment.
| ckeditor=field.name+'_' | |
| ckeditor = field.name + '_' |
| .catch( error => { | ||
| console.error( error ); | ||
| }); | ||
| document.querySelector( '#submit' ).addEventListener( 'click', () => { |
There was a problem hiding this comment.
What if the user uses a different id for the submit button?
|
Hi, thanks for working on this. I think this PR is still incomplete:
|
Hello, I build CKEditor5 in this RP.
The user can use ckeditor4 or ckeditor5 by choosing different CKEditor class
app = CKEditor4(app) #for ckeditor4app = CKEditor5(app) #for ckeditor5and change the editor_type (support CKEditor5 only) by setting config
`CKEDITOR_EDITOR_TYPE = 'classic' #and all of the following
hope you will like it!