allow configuring smart tab to always trigger completion instead #10537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's always been pretty difficult to reliably use tab to select completions - if autocompletion is enabled, it's very easy to press tab before the autocomplete menu loads, which previously just inserted a literal tab and now jumps the cursor around unexpectedly. i'd really like to be able to use tab solely for completion, and this accomplishes that pretty well. the main thing i'm unsure about here is how the configuration should work here - it feels like this would be a lot simpler if i could just map the smart tab action to an arbitrary command, but MappableCommand is defined in helix-term, so it's not available to use as part of the editor.smart-tab config section which is defined in helix-view. that said, there aren't really that many other actions that really make sense to be triggered by smart tab, so maybe this is fine? we could also potentially replace
enable: true
withmode: InsertTab
or something along those lines, but i don't really have strong feelings either way there.