Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added getting metadata from a note id #54

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

darkdecoy
Copy link

Added getting metadata from a note id
Updated help menu and example for info command
Add json format option to info command

Add json format option to info command
Fixed issue with returning all parts of the metadata
Updated help menu and example for info command
Add json format option to info command
Fixed issue with returning all parts of the metadata

Signed-off-by: Dark Decoy <[email protected]>
Copy link
Member

@ErikMichelson ErikMichelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor remarks from my side

bin/hedgedoc Outdated Show resolved Hide resolved
bin/hedgedoc Outdated Show resolved Hide resolved
bin/hedgedoc Outdated Show resolved Hide resolved
Updated error messages

Signed-off-by: Dark Decoy <[email protected]>
Updated --raw option which returns bash array

Signed-off-by: Dark Decoy <[email protected]>
Copy link
Member

@ErikMichelson ErikMichelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --raw is a good idea in my opinion.

Unfortunately, there is one (new) bug still open to fix.
Btw thanks for your patience and fast updates of this PR! :)

bin/hedgedoc Show resolved Hide resolved
Signed-off-by: Dark Decoy <[email protected]>
Copy link
Member

@ErikMichelson ErikMichelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Works well. Thanks for your PR! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants