WIP: CodiMD CLI config file #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the CodiMD CLI relies on information like the remote server, it would be useful to have this information provided in a config file. A simple env file seems like an easy way to store data. This patch implements a very basic functionality to have such a config file.
Open
hugopeixoto
reviewed
Nov 3, 2021
| @@ -190,8 +194,19 @@ function delete_history() { | |||
| fi | |||
| } | |||
|
|
|||
| function write_config() { | |||
| # Backup current config | |||
| cp "$CONFIG_FILE" "$CONFIG_FILE.bak" | |||
There was a problem hiding this comment.
Won't this fail if it's the first time writing the config? I think we need the [ -e ] check here.
I'd also add a warning message saying we generated the backup file if it is generated, so people can clean it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the CodiMD CLI relies on information like the remote server, it
would be useful to have this information provided in a config file. A
simple env file seems like an easy way to store data.
This patch implements a very basic functionality to have such a config
file.