Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cwltool/schema-salad setup to be more resiliant #90

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Jun 27, 2023

expected_mypy_success=True as well

@mr-c mr-c marked this pull request as draft June 27, 2023 01:48
@mr-c mr-c marked this pull request as ready for review June 27, 2023 01:50
@mr-c
Copy link
Contributor Author

mr-c commented Jun 27, 2023

Tested locally with mypy_primer -k common-workflow-language

@mr-c
Copy link
Contributor Author

mr-c commented Nov 22, 2023

This is ready for review and merging, thanks!

@A5rocks
Copy link
Contributor

A5rocks commented Nov 26, 2023

I'm not sure grep here is allowed because mypy-primer should (though it's kinda bad at it) be able to run on Windows.

... though tbh I was looking at making mypy-primer run on Windows and ended up having to exclude projects so a only_platform kwarg might work well...

@mr-c
Copy link
Contributor Author

mr-c commented Nov 27, 2023

I'm not sure grep here is allowed because mypy-primer should (though it's kinda bad at it) be able to run on Windows.

... though tbh I was looking at making mypy-primer run on Windows and ended up having to exclude projects so a only_platform kwarg might work well...

Then cwltool and schema-salad should be excluded from MS Windows anyhow, as they explicitly don't support that platform 😊

So, I'd like the keep the grep.

Copy link
Owner

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, would you mind marking it using the nice supported_platforms annotation A5rocks added in https://github.com/hauntsaninja/mypy_primer/pull/110/files

`expected_mypy_success=True` as well
@mr-c
Copy link
Contributor Author

mr-c commented Nov 29, 2023

@hauntsaninja Done, thank you!

@hauntsaninja hauntsaninja merged commit b75d4ba into hauntsaninja:master Nov 29, 2023
1 check passed
@mr-c mr-c deleted the patch-1 branch November 29, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants