Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change unwrap to extract in overMatL' and overMatM' #364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jjdosa
Copy link

@jjdosa jjdosa commented Dec 18, 2022

@lsg6140 and I've found this bug in the overMatL' and overMatM' functions.

A reduced example case we found is that

{-# LANGUAGE DataKinds #-}

module Main where

import qualified Numeric.LinearAlgebra.Static as H
rmat = H.matrix [1,2,3,4] :: H.L 2 2
cmat = H.matrix [1,2,3,4] :: H.M 2 2

invDiagR = H.inv $ H.diag (H.vector [1,2] :: H.R 2)
invDiagC = H.inv $ H.diag (H.vector [1,2] :: H.C 2)

After loading this module in ghci, executing invDiagR and invDiagC produces these errors:

*Main> invDiagR
*** Exception: inv of nonsquare (1x3) matrix
CallStack (from HasCallStack):
  error, called at src/Internal/Algorithms.hs:706:21 in hmatrix-0.20.2-inplace:Internal.Algorithms
*Main> invDiagC
*** Exception: inv of nonsquare (1x3) matrix
CallStack (from HasCallStack):
  error, called at src/Internal/Algorithms.hs:706:21 in hmatrix-0.20.2-inplace:Internal.Algorithms

By replacing unwrap with extract in the definition of overMatL and overMatM functions, we've
checked that we have the expected results:

*Main> invDiagR 
(matrix
 [ 1.0, 0.0
 , 0.0, 0.5 ] :: L 2 2)
*Main> invDiagC
(matrix
 [ 1.0 :+ 0.0, 0.0 :+ 0.0
 , 0.0 :+ 0.0, 0.5 :+ 0.0 ] :: M 2 2)

@idontgetoutmuch
Copy link
Member

idontgetoutmuch commented Dec 21, 2022

I am struggling with the linker on my m1 Mac atm - I hope to fix this tomorrow and then I can test your PR - thanks for contributing :-)

@jjdosa
Copy link
Author

jjdosa commented Dec 22, 2022

Thank you @idontgetoutmuch for the feedback!

You can ignore the rmat and camt matrices as they are unused.

rmat = H.matrix [1,2,3,4] :: H.L 2 2
cmat = H.matrix [1,2,3,4] :: H.M 2 2

They are there because I forgot to remove them after reducing these examples

invDiagR = H.inv $ H.diag (H.takeDiag rmat)
invDiagC = H.inv $ H.diag (H.takeDiag cmat)

into the ones in the PR message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants