terraform apply -json plan.file: Aligns the plan output to be the same regardless of whether a plan file is used
#36245
+4
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magodo
changed the title
terraform apply -json plan.file: Aligns the plan output to be the same regardless of whether a plan file is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends for the machine readable UI when applying against a plan file, from only displaying the per resource "planned_change", to be the same as how the
plancommand displays, which includes:This is extreamly useful for toolings that re-use a same logic for processing the
applyjson outputs, no matter it is ran with a plan file or not.The PR simply removes the
PlannedChangemethod from theviews.Operationinterface, as it is only used as an if-like trick for displaying the per resource "planned_change" for json view when applying with plan case. Instead, this PR just type checks the view and reuses thePlanmethod.Target Release
1.11.x
Draft CHANGELOG entry
ENHANCEMENTS
terraform apply -json plan.file: Aligns the plan output to be the same regardless of whether a plan file is used.