Skip to content
This repository has been archived by the owner on Dec 8, 2020. It is now read-only.

Add deploy keys and user SSH keys resources #48

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ricbir
Copy link

@ricbir ricbir commented Jan 23, 2020

This pull request adds bitbucket_repository_deploy_key resource for adding deploy keys to a repository, and bitbucket_user_ssh_key for adding SSH keys to a user.
It works very well in conjunction with the tls_private_key resource.

@cwood
Copy link
Contributor

cwood commented Jan 23, 2020

Hi can you move this into two different PRs? I don't get why the vendor updates are there. Can you just make this PR about the new features you want to add?

@cwood
Copy link
Contributor

cwood commented Jan 23, 2020

Ah nvm I see this just pulls in a giant amount of deps because of x/crypto

@cwood
Copy link
Contributor

cwood commented Jan 23, 2020

  • add docs

Copy link
Contributor

@cwood cwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add docs to this PR. Other then that it seems fine

@ricbir ricbir force-pushed the master branch 2 times, most recently from ebb8290 to 849103f Compare January 24, 2020 10:53
@cwood
Copy link
Contributor

cwood commented Jan 24, 2020

It looks like you are missing a page in the bitbucket.erb to link to it. If you do make website it should create the docker containers so you can preview the site and your docs.

@ricbir
Copy link
Author

ricbir commented Jan 24, 2020

Ah I see now. Apologies, I am new to this!

@cwood
Copy link
Contributor

cwood commented Jan 24, 2020

Its no worries. Thanks for making these PRs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants