This repository has been archived by the owner on Dec 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 105
Add deploy keys and user SSH keys resources #48
Open
ricbir
wants to merge
6
commits into
hashicorp:master
Choose a base branch
from
ricbir:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi can you move this into two different PRs? I don't get why the vendor updates are there. Can you just make this PR about the new features you want to add? |
Ah nvm I see this just pulls in a giant amount of deps because of x/crypto |
|
cwood
reviewed
Jan 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add docs to this PR. Other then that it seems fine
ricbir
force-pushed
the
master
branch
2 times, most recently
from
January 24, 2020 10:53
ebb8290
to
849103f
Compare
It looks like you are missing a page in the bitbucket.erb to link to it. If you do |
Ah I see now. Apologies, I am new to this! |
Its no worries. Thanks for making these PRs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds
bitbucket_repository_deploy_key
resource for adding deploy keys to a repository, andbitbucket_user_ssh_key
for adding SSH keys to a user.It works very well in conjunction with the
tls_private_key
resource.