Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate tagging tests for ACM #37556

Merged
merged 5 commits into from
May 16, 2024
Merged

Generate tagging tests for ACM #37556

merged 5 commits into from
May 16, 2024

Conversation

gdavison
Copy link
Contributor

Description

Generates tagging tests for ACM.

Also allows omitting rName variable from generated acceptance test configurations

Output from Acceptance Testing

% make testacc TESTS='[Tt]ags' PKG=acm

--- PASS: TestAccACMCertificate_tags_DefaultTags_nullNonOverlappingResourceTag (84.69s)
--- PASS: TestAccACMCertificate_tags_DefaultTags_nullOverlappingResourceTag (85.19s)
--- PASS: TestAccACMCertificate_tags_ComputedTag_OnCreate (97.11s)
--- PASS: TestAccACMCertificate_tags_DefaultTags_emptyResourceTag (97.53s)
--- PASS: TestAccACMCertificate_tags_null (101.52s)
--- PASS: TestAccACMCertificate_tags_DefaultTags_updateToResourceOnly (115.11s)
--- PASS: TestAccACMCertificate_tags_AddOnUpdate (115.46s)
--- PASS: TestAccACMCertificate_tags_DefaultTags_updateToProviderOnly (118.85s)
--- PASS: TestAccACMCertificate_tags_ComputedTag_OnUpdate_Replace (119.54s)
--- PASS: TestAccACMCertificate_tags_ComputedTag_OnUpdate_Add (121.20s)
--- PASS: TestAccACMCertificate_tags_EmptyTag_OnCreate (122.56s)
--- PASS: TestAccACMCertificate_tags_EmptyTag_OnUpdate_Replace (124.09s)
--- PASS: TestAccACMCertificate_PrivateKey_ReimportWithTags (124.85s)
--- PASS: TestAccACMCertificate_tags_EmptyTag_OnUpdate_Add (138.52s)
--- PASS: TestAccACMCertificate_tags_DefaultTags_overlapping (145.54s)
--- PASS: TestAccACMCertificate_tags_DefaultTags_nonOverlapping (149.82s)
--- PASS: TestAccACMCertificate_tags (158.08s)
--- PASS: TestAccACMCertificate_tags_DefaultTags_providerOnly (159.26s)

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iam Issues and PRs that pertain to the iam service. service/acm Issues and PRs that pertain to the acm service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/batch Issues and PRs that pertain to the batch service. service/acmpca Issues and PRs that pertain to the acmpca service. service/xray Issues and PRs that pertain to the xray service. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. generators Relates to code generators. labels May 15, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 15, 2024
ewbankkit
ewbankkit approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@gdavison gdavison merged commit 9337095 into main May 16, 2024
36 checks passed
@gdavison gdavison deleted the td-generate-tagtests-acm branch May 16, 2024 18:05
@github-actions github-actions bot added this to the v5.50.0 milestone May 16, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
generators Relates to code generators. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/acm Issues and PRs that pertain to the acm service. service/acmpca Issues and PRs that pertain to the acmpca service. service/batch Issues and PRs that pertain to the batch service. service/iam Issues and PRs that pertain to the iam service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/xray Issues and PRs that pertain to the xray service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.50.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gdavison @ewbankkit