Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate transfer resources to AWS Go SDKv2 #37548

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Migrate transfer resources to AWS Go SDKv2 #37548

wants to merge 9 commits into from

Conversation

DanielRieske
Copy link
Contributor

@DanielRieske DanielRieske commented May 15, 2024 •
edited

Description

This PR migrates the transfer resources to AWS SDKv2.

Relations

Closes #36216

References

Output from Acceptance Testing

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransfer_serial -timeout 360m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Agreement
=== RUN   TestAccTransfer_serial/Agreement/basic
=== RUN   TestAccTransfer_serial/Agreement/disappears
=== RUN   TestAccTransfer_serial/Agreement/tags
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/SecurityPolicy
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCToPublic
=== RUN   TestAccTransfer_serial/Server/DataSourceBasic
=== RUN   TestAccTransfer_serial/Server/ForceDestroy
=== RUN   TestAccTransfer_serial/Server/LambdaFunction
=== RUN   TestAccTransfer_serial/Server/ProtocolDetails
=== RUN   TestAccTransfer_serial/Server/SecurityPolicyFIPS
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPC
=== RUN   TestAccTransfer_serial/Server/VPC
=== RUN   TestAccTransfer_serial/Server/VPCEndpointID
=== RUN   TestAccTransfer_serial/Server/APIGatewayForceDestroy
=== RUN   TestAccTransfer_serial/Server/DataSourceServiceManaged
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/Workflow
=== RUN   TestAccTransfer_serial/Server/disappears
=== RUN   TestAccTransfer_serial/Server/AuthenticationLoginBanners
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPC
=== RUN   TestAccTransfer_serial/Server/StructuredLogDestinations
=== RUN   TestAccTransfer_serial/Server/Protocols
=== RUN   TestAccTransfer_serial/Server/SftpAuthenticationMethods
=== RUN   TestAccTransfer_serial/Server/S3StorageOptions
=== RUN   TestAccTransfer_serial/Server/UpdateSftpAuthenticationMethods
=== RUN   TestAccTransfer_serial/Server/VPCAddressAllocationIDsSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/VPCSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/tags
=== RUN   TestAccTransfer_serial/Server/HostKey
=== RUN   TestAccTransfer_serial/Server/DataSourceAPIGateway
=== RUN   TestAccTransfer_serial/Server/DirectoryService
=== RUN   TestAccTransfer_serial/Server/Domain
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/VPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/basic
=== RUN   TestAccTransfer_serial/Server/APIGateway
=== RUN   TestAccTransfer_serial/SSHKey
=== RUN   TestAccTransfer_serial/SSHKey/basic
=== RUN   TestAccTransfer_serial/Tag
=== RUN   TestAccTransfer_serial/Tag/Value
=== RUN   TestAccTransfer_serial/Tag/System
=== RUN   TestAccTransfer_serial/Tag/basic
=== RUN   TestAccTransfer_serial/Tag/disappears
=== RUN   TestAccTransfer_serial/User
=== RUN   TestAccTransfer_serial/User/basic
=== RUN   TestAccTransfer_serial/User/disappears
=== RUN   TestAccTransfer_serial/User/tags
=== RUN   TestAccTransfer_serial/User/HomeDirectoryMappings
=== RUN   TestAccTransfer_serial/User/ModifyWithOptions
=== RUN   TestAccTransfer_serial/User/Posix
=== RUN   TestAccTransfer_serial/User/UserNameValidation
=== RUN   TestAccTransfer_serial/Access
=== RUN   TestAccTransfer_serial/Access/disappears
=== RUN   TestAccTransfer_serial/Access/EFSBasic
=== RUN   TestAccTransfer_serial/Access/S3Basic
=== RUN   TestAccTransfer_serial/Access/S3Policy
--- PASS: TestAccTransfer_serial (14378.13s)
    --- PASS: TestAccTransfer_serial/Agreement (633.41s)
        --- PASS: TestAccTransfer_serial/Agreement/basic (250.73s)
        --- PASS: TestAccTransfer_serial/Agreement/disappears (193.58s)
        --- PASS: TestAccTransfer_serial/Agreement/tags (189.09s)
    --- PASS: TestAccTransfer_serial/Server (7584.95s)
        --- PASS: TestAccTransfer_serial/Server/SecurityPolicy (246.91s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCAddressAllocationIDs (213.97s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCToPublic (228.87s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceBasic (191.90s)
        --- PASS: TestAccTransfer_serial/Server/ForceDestroy (197.41s)
        --- PASS: TestAccTransfer_serial/Server/LambdaFunction (216.58s)
        --- PASS: TestAccTransfer_serial/Server/ProtocolDetails (165.26s)
        --- PASS: TestAccTransfer_serial/Server/SecurityPolicyFIPS (205.35s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPC (297.47s)
        --- PASS: TestAccTransfer_serial/Server/VPC (141.85s)
        --- PASS: TestAccTransfer_serial/Server/VPCEndpointID (75.60s)
        --- PASS: TestAccTransfer_serial/Server/APIGatewayForceDestroy (170.99s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceServiceManaged (194.32s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCSecurityGroupIDs (104.57s)
        --- PASS: TestAccTransfer_serial/Server/Workflow (341.31s)
        --- PASS: TestAccTransfer_serial/Server/disappears (183.19s)
        --- PASS: TestAccTransfer_serial/Server/AuthenticationLoginBanners (195.13s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPC (75.85s)
        --- PASS: TestAccTransfer_serial/Server/StructuredLogDestinations (210.05s)
        --- PASS: TestAccTransfer_serial/Server/Protocols (231.21s)
        --- PASS: TestAccTransfer_serial/Server/SftpAuthenticationMethods (201.98s)
        --- PASS: TestAccTransfer_serial/Server/S3StorageOptions (209.01s)
        --- PASS: TestAccTransfer_serial/Server/UpdateSftpAuthenticationMethods (185.92s)
        --- PASS: TestAccTransfer_serial/Server/VPCAddressAllocationIDsSecurityGroupIDs (221.12s)
        --- PASS: TestAccTransfer_serial/Server/VPCSecurityGroupIDs (65.81s)
        --- PASS: TestAccTransfer_serial/Server/tags (185.11s)
        --- PASS: TestAccTransfer_serial/Server/HostKey (163.72s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceAPIGateway (196.56s)
        --- PASS: TestAccTransfer_serial/Server/DirectoryService (956.11s)
        --- PASS: TestAccTransfer_serial/Server/Domain (195.42s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPCAddressAllocationIDs (414.71s)
        --- PASS: TestAccTransfer_serial/Server/VPCAddressAllocationIDs (290.04s)
        --- PASS: TestAccTransfer_serial/Server/basic (207.72s)
        --- PASS: TestAccTransfer_serial/Server/APIGateway (203.91s)
    --- PASS: TestAccTransfer_serial/SSHKey (167.35s)
        --- PASS: TestAccTransfer_serial/SSHKey/basic (167.35s)
    --- PASS: TestAccTransfer_serial/Tag (782.45s)
        --- PASS: TestAccTransfer_serial/Tag/Value (206.42s)
        --- PASS: TestAccTransfer_serial/Tag/System (187.01s)
        --- PASS: TestAccTransfer_serial/Tag/basic (195.72s)
        --- PASS: TestAccTransfer_serial/Tag/disappears (193.30s)
    --- PASS: TestAccTransfer_serial/User (1210.37s)
        --- PASS: TestAccTransfer_serial/User/basic (166.56s)
        --- PASS: TestAccTransfer_serial/User/disappears (193.59s)
        --- PASS: TestAccTransfer_serial/User/tags (219.60s)
        --- PASS: TestAccTransfer_serial/User/HomeDirectoryMappings (220.31s)
        --- PASS: TestAccTransfer_serial/User/ModifyWithOptions (218.69s)
        --- PASS: TestAccTransfer_serial/User/Posix (177.51s)
        --- PASS: TestAccTransfer_serial/User/UserNameValidation (14.11s)
    --- PASS: TestAccTransfer_serial/Access (3999.60s)
        --- PASS: TestAccTransfer_serial/Access/disappears (966.53s)
        --- PASS: TestAccTransfer_serial/Access/EFSBasic (1149.75s)
        --- PASS: TestAccTransfer_serial/Access/S3Basic (937.55s)
        --- PASS: TestAccTransfer_serial/Access/S3Policy (945.78s)
PASS
ok	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	14382.252s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/transfer Issues and PRs that pertain to the transfer service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. flex Pertains to FLatteners and EXpanders. generators Relates to code generators. labels May 15, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels May 15, 2024
@ewbankkit ewbankkit added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label May 15, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label May 16, 2024
@ewbankkit ewbankkit self-assigned this May 22, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 22, 2024
@aristosvo aristosvo mentioned this pull request May 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ewbankkit ewbankkit

Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. flex Pertains to FLatteners and EXpanders. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/transfer Issues and PRs that pertain to the transfer service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] Transfer Family Service
3 participants
@DanielRieske @ewbankkit @justinretzolk