Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue delete volume based VM twice #127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhenggu
Copy link
Contributor

@zhenggu zhenggu commented May 30, 2024

There is a issue that while build image on volume based VM, the VM will be delete twice
图片
The first "Terminating the source server" comes from

err := DeleteServer(state, instance)
and the second comes from
err := DeleteServer(state, s.server.ID)

Before volume based VM, it is good to store the instance information into StepRunSourceServer, but for now, StepDeleteServer also does something on it, so I think it is not good to store it as a parameter of StepRunSourceServer right now.
I know my solution is not good, but I want good suggestion on it.

  1. I am not sure state is a good place to store it, but seems it is the only way I known to do communicate between steps.
  2. State "instance_id" has been handled, but not on state "server".
  3. Is it good if we can add a new state to identify the server has already been delete?

@zhenggu zhenggu requested a review from a team as a code owner May 30, 2024 02:26
@zhenggu zhenggu changed the title Fix the issue volume based VM deleted twice Fix the issue delete volume based VM twice May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant