Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifier hds-register-event - Convert to TypeScript #2103

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

didoo
Copy link
Contributor

@didoo didoo commented May 16, 2024

📌 Summary

Converts the hds-register-event modifier to TypeScript

🔗 External links

Jira ticket: https://hashicorp.atlassian.net/browse/HDS-3337


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@didoo didoo requested a review from a team May 16, 2024 14:56
Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview May 22, 2024 11:33am
hds-website ✅ Ready (Inspect) Visit Preview May 22, 2024 11:33am

Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I believe this is our first modifier being converted 🙌

packages/components/src/template-registry.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants