-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifier hds-register-event
- Convert to TypeScript
#2103
Open
didoo
wants to merge
6
commits into
main
Choose a base branch
from
hds-register-event-ts-conversion
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+69
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced May 16, 2024
didoo
force-pushed
the
hds-register-event-ts-conversion
branch
from
May 16, 2024 15:57
edce147
to
d36152c
Compare
didoo
commented
May 16, 2024
didoo
force-pushed
the
hds-register-event-ts-conversion
branch
from
May 17, 2024 10:34
603562e
to
5cda928
Compare
1 task
didoo
force-pushed
the
hds-register-event-ts-conversion
branch
from
May 17, 2024 17:13
5cda928
to
6de82ce
Compare
alex-ju
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I believe this is our first modifier being converted 🙌
didoo
force-pushed
the
hds-register-event-ts-conversion
branch
from
May 20, 2024 13:41
6de82ce
to
9c9e1a0
Compare
didoo
force-pushed
the
hds-register-event-ts-conversion
branch
from
May 20, 2024 13:45
9c9e1a0
to
09d163c
Compare
didoo
force-pushed
the
hds-register-event-ts-conversion
branch
from
May 21, 2024 09:27
09d163c
to
27779af
Compare
didoo
force-pushed
the
hds-register-event-ts-conversion
branch
from
May 21, 2024 22:16
27779af
to
11dc561
Compare
didoo
force-pushed
the
hds-register-event-ts-conversion
branch
from
May 22, 2024 11:30
11dc561
to
6ce3d92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Converts the
hds-register-event
modifier to TypeScript🔗 External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-3337
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.