Fathom Event Tracking #2082
Fathom Event Tracking #2082
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @route={{@route}} | ||
| @models={{this.models}} | ||
| ...attributes | ||
| {{on "click" (fn this.eventTracking.trackEvent @eventName)}} |
There was a problem hiding this comment.
@Dhaulagiri while discussing modifiers with @aklkv he mentioned that this could be a custom modifier (it would make the code cleaner). He can probably expand on this more, but something to consider, it would look something like this: {{doc-track-event @eventName}} (all the logic would be isolated in the modifier)
There was a problem hiding this comment.
ooh, that sounds interesting. Admittedly I built this based on my very stale ember knowledge, so if there is a more idiomatic, current way to do this I'm open to refactoring this.
There was a problem hiding this comment.
|
I'm going to merge what I have here for now. I'll make a note about the modifier suggestion and add it to a follow-up epic I'm building for this work. |
📌 Summary
This PR creates an event tracking service to send events to Fathom and wires up a few proposed events as a starting point
🛠️ Detailed description
Under the hood this is built using a Service which can be injected wherever we want to track events. I tried to keep the naming relatively agnostic as, in theory, Fathom could be replaced at some point.
📸 Screenshots
💬 Please consider using conventional comments when reviewing this PR.