-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add test for checking existannce of public/hash.txt file #1010
base: main
Are you sure you want to change the base?
Conversation
@NoamGaash Added comment from previous commit for context: In short, updated the commit hash in hash.txt in the build.yaml file seems like you're testing for the existence of public/hash.txt - and I don't think we should expect this file to be found in this stage because this job is not the same job that created this file. Updated this commit according to what you asked |
23d59a7
to
1d0f6b6
Compare
Updated the test in the validate section. It seems now that it redirects it to the main page again for my opinion ( this is why we have 3100 chars and not less than 100 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Try to run the image locally and see A) if it has the file inside the public
directory and b) if it serve it
exit 1 | ||
fi | ||
mime_type=$(file --mime-type -b /tmp/hash.txt) | ||
if [ "$mime_type" != "text/html" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if [ "$mime_type" != "text/html" ]; then | |
if [ "$mime_type" != "text/plain" ]; then |
fix: add test for checking existannce of public/hash.txt file