fix: fix hash.txt issue from build.yaml

[ofirc77]

Description

Test and fix the issue with hash.txt file that needs to be created during the build process

[github-actions]

Preview: https://s3.amazonaws.com/noam-gaash.co.il/12792189377/open-bus/287/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/12792189377/open-bus/287/storybook/index.html
Test Report (if available): 'https://s3.amazonaws.com/noam-gaash.co.il/12792189377/open-bus/0d14fd741afdd1ee377ae5bfd68a93f38d45069e/test-results/index.html'

[NoamGaash]

Hi :)
Thanks for working on it
Just making sure we're on the same page - the preview uses s3 storage, so the fact the commit sha is available on https://s3.amazonaws.com/noam-gaash.co.il/12659976140/open-bus/268/hash.txt doesn't guarantee it will be served from the nginx docker file used in production. Anyway, we can try merging it and see if it helps 🤞 🙏
It is possible to add a verification in the test workflow, as it's using the real docker image that will be deployed to production later:

open-bus-map-search/.github/workflows/validate.yaml

Lines 77 to 78 in 1a5b121

	- name: Run application
	run: docker run -d -p 3000:80 ${{ env.DOCKER_APP_IMAGE_NAME }}:${{ env.DOCKER_APP_IMAGE_TAG }}

[ofirc77]

I added the test for file existence as you said and it seems to be missing.
I will try to think of another solution. Please assist if you have ideas

[NoamGaash]

seems like you're testing for the existence of public/hash.txt - and I don't think we should expect this file to be found in this stage because this job is not the same job that created this file.
I do think we want to test that http://localhost:3000/hash.txt returns a text string (mime type text/plain) that is short (less then 100 chars or so).
This test can also be performed locally if you run docker build and docker run, and then navigate to this url in your browser.
also, please consider adding separated commits so it will be easier to follow what have we tried

[ofirc77]

I will push this commit and create another one for the fix that you mentioned