Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated tests and grunt configuration #2737

Merged
merged 3 commits into from
Nov 27, 2016
Merged

Conversation

koenpunt
Copy link
Collaborator

@koenpunt koenpunt commented Oct 21, 2016

  • added the max_shown_results spec for prototype.
  • replaced event.simulate library with something that can fire any event (namely keyup)
  • updated the grunt tasks;
    • watch watch sources and tests, and build and run tests on change.
    • watch:test only watch for changes in test files.
    • test build all sources and runs all tests.
    • test:jquery build jquery source and run jquery tests.
    • test:proto build proto source and run proto tests.

@koenpunt
Copy link
Collaborator Author

✨ @harvesthq/chosen-developers @stof

@adunkman
Copy link
Contributor

4a9f15f seems pretty unrelated and subjective (I tend to favor double quotes always since there’s no reason not to) and makes this diff pretty hard to review. Can we pull that out into another PR if you’re heart-set on it?

@koenpunt
Copy link
Collaborator Author

koenpunt commented Oct 29, 2016

4a9f15f seems pretty unrelated and subjective

True, but just trying to get some sort of consistency throughout the project. But I can move these changes to the Coffeelint PR (#2738)

- updated watch tasks for use with the tests
- let uglify mangle
- more separation between jquery and proto
- more separation between main scripts and tests
@koenpunt
Copy link
Collaborator Author

koenpunt commented Nov 3, 2016

I tend to favor double quotes always since there’s no reason not to

I prefer single, because it doesn't require me to press shift to type it.

But I removed that commit, do you have anything else to add to this? :)

@koenpunt koenpunt merged commit 60cdbb7 into harvesthq:master Nov 27, 2016
@koenpunt koenpunt deleted the tests branch November 27, 2016 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants