General touchup #2733
Open
General touchup #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace custom bound @activate_action with using a fat-arrow function
removed the need for the manual bind, which is what coffeescript does in the background
koenpunt
force-pushed
the
general-touchup
branch
from
056fa9e to
5dd350a
Compare
stof
reviewed
Jul 24, 2017
| @search_field.bind 'cut.chosen', (evt) => this.clipboard_event_checker(evt); return | ||
| @search_field.bind 'paste.chosen', (evt) => this.clipboard_event_checker(evt); return | ||
| @container.bind 'touchstart.chosen', this.container_mousedown | ||
| @container.bind 'touchend.chosen', this.container_mouseup |
There was a problem hiding this comment.
we must be sure that these methods can never return false by mistake, as this would stop propagation and prevent default.
And the automatic return of CoffeeScript could hide this from us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search_field_disabledhas now less code duplicationset tabindex on original variable instead of through the jQuery instance
clean up some functions unused arguments
replace custom function scoping with fat arrow functions at their definitions
So instead of:
It's now:
It might be necessary to restore some of the
returnstatements at the end of the functions, although I have not seen issue yet without them.