Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow removing existing votes #30

Open
juansalmeronmoya opened this issue Feb 23, 2018 · 6 comments
Open

Feature: Allow removing existing votes #30

juansalmeronmoya opened this issue Feb 23, 2018 · 6 comments

Comments

@juansalmeronmoya
Copy link

It would be nice to let voters to remove any entry.

@hartwork
Copy link
Owner

hartwork commented Feb 25, 2018

Hi! Why do you consider that beneficial? What's the use case?

@juansalmeronmoya
Copy link
Author

It's a fast feature that enable remove and edit votes in a trusted environment (like a group of colleagues) without the need of any user management. Of course, with users and admins its betters, but this is a nice feature that can be reused in the moment that restricted when user administration will be added in the future, just restricting this feature to admins or poll creators for example. At this moment could be nice to choose to enable removing by configuration.

@hartwork hartwork changed the title Remove votes Feature: Allow removing existing votes Feb 26, 2018
@LaQuay
Copy link

LaQuay commented Mar 12, 2018

Waiting for this, too. Thanks!

@hartwork
Copy link
Owner

Interesting.

I would like to note that with this feature added in the simplest anyone-can-delete-any-vote version a single person could delete all existing entries and create new ones with the same names but different votes and it would taker a rather close look and memory and recent visit to the poll to notice. So in my world that approach stops working in an environment where you have below 99% trust in each other, e.g. at work. So outside of your core friends and family this will probably not work out well.

With that being said, I can think of a way to implement it that may not take days.
If I did that, I wonder if the config JSON should be added a new field field with the feature disabled by default or if the flag should be hidden because when we keep adding visible flags, user experience will go downhill quickly.

What do you think?

@LaQuay
Copy link

LaQuay commented Mar 14, 2018

@hartwork Yeah, +1 to your idea. Just a flag disabled by default, with the possibility of enabling it when the admin creates the poll.

And something like if it is enabled and someone makes a hover on the name, open a floating label with the possibility of deleting it

Thanks!

@juansalmeronmoya
Copy link
Author

On my opinion, this aproach it's okay for that purpose.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants