-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: competition 2 BaseANN changes #111
base: main
Are you sure you want to change the base?
Conversation
We need to add insert and delete too |
To be more specific, lets use batch_insert() and batch_delete(). |
@sourcesync Thanks so much for going ahead with this! As I understood, there is no hybrid query, but only a dense query, add, remove (possible with metadata) and a sparse query. Given these different settings, I think it makes more sense to have My plan was to merge the baselines next week and then refactor the code around them. It would be great if we could join forces @sourcesync |
Awesome @Martin Aumüller. Yeah, I think approaching this with different base classes is a great choice esp. if "hybrid" is not a part of this competition. ( Note that if you already have a branch / PR going, I'm quite happy to close this draft PR...) |
This is a draft PR to get ideas/feedback around possible changes to BaseANN for the second competition.
Assumptions:
Possible Approaches:
( @harsha-simhadri had asked me to kick-start this, but if anything has already been done here I'm happy close this PR )