Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [PL-58650]: Terraform Changes for Add support for configuring recovery duration in AWS Secrets Manager Connector for secret deletion flow #620

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sahibaHarness
Copy link
Contributor

Describe your changes

This PR covers changes to give user ability to retrieve a deleted secret in AWS Secret Manager if accidentaly deleted from Harness. When configuring a AWS SM connector in Harness use can now choose between two additional fields:

Tested for:

  • Created connector with recovery period of 15 days
  • Error is thrown when recovery period is selected as 5
  • Created connector with ForceDeleteWithoutRecovery as true
Assume Role using STS on Delegate Credertial Type © Pasted Graphic 31

Comment Triggers

PR Check triggers
  • Build: trigger build
  • gitleaks: trigger gitleaks

…ecovery duration in AWS Secrets Manager Connector for secret deletion flow
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants