Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDS-105245] Added Google Cloud Run Job step details #8919

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vishal-av
Copy link
Collaborator

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.

Description

  • Please describe your changes: __________________________________
  • Jira/GitHub Issue numbers (if any): ______________________________
  • Preview links/images (Internal contributors only): __________________

PR lifecycle

We aim to merge PRs within one week or less, but delays happen sometimes.

If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.

PRs must meet these requirements to be merged:

  • Successful preview build.
  • Code owner review.
  • No merge conflicts.
  • Release notes/new features docs: Feature/version released to at least one prod environment.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6762d165dd150200819e4d5d--harness-developer.netlify.app

Copy link
Collaborator

@SushrutHarness SushrutHarness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, in general the site looks a little off when I was trying to understand the section added.

Thanks!

Here's a high-level summary of the setup steps:
A **Google Cloud Run Job**, on the other hand, is a one-off, task-based execution model where the container runs to completion. Jobs are used for batch processing, scheduled tasks, and background workloads that don't require continuous execution. While Services remain active to handle incoming requests, Jobs are designed to start, run a task, and then exit once complete.

## Google CLoud Run Service
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Google CLoud Run Service
## Google Cloud Run Service

@@ -105,6 +109,57 @@ Here's a high-level summary of the setup steps:

10. Select **Save**, and then run the pipeline.

## Google CLoud Run Job
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Google CLoud Run Job
## Google Cloud Run Job


![](static/google-cloud-run-job.png)

**Container Configuration**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making these headers with ### so that its more visually distinct.


For Container Configuration, you need to set up a connector to the container registry.

For Container Registry, create or select a Docker connector to access the container registry.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're referencing a UI element, it should be bold. In this case Container Registry and Container Configuration


**Deploy and Execute Steps**

The **Deploy Step** uses the `gcloud run jobs replace` command to apply the YAML manifest provided by the user.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have separate deploy & execute steps here. The same job step first runs the replace command and then the execute command.


For Container Registry, create or select a Docker connector to access the container registry.
For Container Configuration, use the following public Docker image:
- [`harness/google-cloud-run-plugin:1.0.0-linux-amd64`](https://hub.docker.com/layers/harness/google-cloud-run-plugin/1.0.0-linux-amd64/images/sha256-2ad0c6d434673e56df47f1014c397d2bbc8248f8e76b5bbd48965f116f4843f2?context=explore).
Copy link
Contributor

@lovish1999 lovish1999 Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add 1.0.1 tag. I had made some fixes for job in the latest release.

@vishal-av vishal-av added the Blocked / On hold On hold due to release delay, build error, question, bug in feature, or otherwise label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked / On hold On hold due to release delay, build error, question, bug in feature, or otherwise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants