fix: [PIPE-24077]: pull request changes page diff viewer comments and filters #634
Conversation
|
|
✅ Deploy Preview for harness-xd-review ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
abhinavrastogi-harness
force-pushed
the
PR-changes-diffViewer
branch
from
513087b to
ee0f992
Compare
| parentCommentId={parent.id} | ||
| handleSaveComment={handleSaveComment} | ||
| isLast={true} | ||
| contentClassName="px-4 py-2 w-[calc(100%-38px)]" |
There was a problem hiding this comment.
Can we move this number 38px as a separate css variable? It'll help with readability and purpose of it.
| } | ||
|
|
||
| // TODO: workon on filter and files viewed | ||
| export const PullRequestChangesFilter: React.FC<FilterViewProps> = ({ |
There was a problem hiding this comment.
nit: As suggested, component and it's props need to have naming convention in a similar manner. PullRequestChangesFilterProps
| refetchActivities() | ||
| }) | ||
| .catch(error => { | ||
| console.error('Failed to delete comment:', error) |
There was a problem hiding this comment.
we should show error inline in the UI, instead of dumping them in the console
| refetchActivities() | ||
| }) | ||
| .catch(error => { | ||
| console.error('Failed to update comment:', error) |
|
|
||
| const handleUnmarkViewed = (filePath: string) => { | ||
| if (diffs) { | ||
| const newDiffs = diffs.map(diff => { |
There was a problem hiding this comment.
can this business logic be moved to the store instead?
pull request changes page diff viewer comments and filters