feat(styles): update summary page #633
Open
+93
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for harness-xd-review ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
iatopilskii
force-pushed
the
feat-upd-summary-page
branch
from
5be6eb4 to
2c0b79c
Compare
shaurya-harness
approved these changes
Jan 6, 2025
abhinavrastogi-harness
approved these changes
Jan 6, 2025
Comment on lines
+24
to
+25
| onClick?.(e) | ||
| setCopied(true) |
There was a problem hiding this comment.
setCopied() should happen first. it's possible that the caller can stop event propagation in the onClick callback
| id="identifier" | ||
| label={t('views:repos.name')} | ||
| value={tokenData?.identifier} | ||
| readOnly | ||
| variant="extended" | ||
| rightElementVariant="default" | ||
| rightElement={<CopyButton name={tokenData?.identifier} />} | ||
| rightElement={<CopyButton name={tokenData?.identifier} onClick={e => e.preventDefault()} />} |
There was a problem hiding this comment.
why do we need preventDefault here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request brings small design updates for repo summary page:
Clone repository
edit README.md