-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: repo description in a dialog #524
Conversation
|
✅ Deploy Preview for harness-xd-review ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/ui/src/views/repo/repo-summary/components/edit-repo-details-dialog.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/views/repo/repo-summary/components/edit-repo-details-dialog.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/views/repo/repo-summary/components/edit-repo-details-dialog.tsx
Outdated
Show resolved
Hide resolved
@andrewgolovanov we set a line-clamp-3 here as well, since max characters can be 1024, it would be spread to almost the bottom of the page. what do you think? |
packages/ui/src/views/repo/repo-summary/components/summary-panel.tsx
Outdated
Show resolved
Hide resolved
@shaurya-harness In that case, I’d reduce the maximum number of characters allowed in the description. We could follow GitHub’s example. Here’s what it looks like when I fill in the repository description with the maximum number of characters: |
okay, will need a backend change for this, I'll mention in our PIPE sync today |
3f6eebb
to
f73d543
Compare
packages/ui/src/views/repo/repo-summary/components/edit-repo-details-dialog.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/views/repo/repo-summary/components/summary-panel.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/views/repo/repo-summary/components/summary-panel.tsx
Outdated
Show resolved
Hide resolved
@andrewgolovanov just had a word with @bradrydzewski , we can't reduce the max chars support at backend as some of our old customers might have long descriptions. we should be looking at truncating to a few lines, earlier it used to be line-clamp-3, we can change that to 8 maybe for parity with github? |
Alright, no problem. In that case, yes, we can limit it to 8 lines, like on GitHub. In the future, we could consider adding a Tooltip that appears when hovering over the description, allowing users to see the full text. But for now, that’s just a rough idea - I plan to discuss it with the design team soon. |
@andrewgolovanov I have also added full width for the repo-summary page as per the figma - https://www.figma.com/design/Lu5QJyq9tQEjHMeQmQhbAd/Gitness-Product-Design---Stage-2?node-id=5318-41915&node-type=canvas&t=kwQAdKoUWXZT5HPm-0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🚀
…etails-dialog.tsx Co-authored-by: Andrew Golovanov <[email protected]>
9963070
to
400fbf8
Compare
repo description in a dialog as per new figma design
also added full width for summary page acc to figma - https://www.figma.com/design/Lu5QJyq9tQEjHMeQmQhbAd/Gitness-Product-Design---Stage-2?node-id=5318-41915&node-type=canvas&t=kwQAdKoUWXZT5HPm-0