Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repo description in a dialog #524

Merged
merged 8 commits into from
Dec 9, 2024
Merged

fix: repo description in a dialog #524

merged 8 commits into from
Dec 9, 2024

Conversation

shaurya-harness
Copy link
Contributor

@shaurya-harness shaurya-harness commented Dec 5, 2024

repo description in a dialog as per new figma design

also added full width for summary page acc to figma - https://www.figma.com/design/Lu5QJyq9tQEjHMeQmQhbAd/Gitness-Product-Design---Stage-2?node-id=5318-41915&node-type=canvas&t=kwQAdKoUWXZT5HPm-0

Screenshot 2024-12-06 at 12 23 28 AM Screenshot 2024-12-06 at 12 23 50 AM Screenshot 2024-12-06 at 12 24 08 AM Screenshot 2024-12-06 at 12 24 18 AM

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for harness-xd-review ready!

Name Link
🔨 Latest commit 400fbf8
🔍 Latest deploy log https://app.netlify.com/sites/harness-xd-review/deploys/675680869caeb100088f40da
😎 Deploy Preview https://deploy-preview-524--harness-xd-review.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewgolovanov
Copy link
Collaborator

From the screenshots provided, it seems that the description is currently being cut off for some reason. This area should adjust its height automatically based on the text and shouldn’t have a fixed height set.

image

@shaurya-harness
Copy link
Contributor Author

From the screenshots provided, it seems that the description is currently being cut off for some reason. This area should adjust its height automatically based on the text and shouldn’t have a fixed height set.

image

@andrewgolovanov we set a line-clamp-3 here as well, since max characters can be 1024, it would be spread to almost the bottom of the page. what do you think?

@andrewgolovanov
Copy link
Collaborator

we set a line-clamp-3 here as well, since max characters can be 1024, it would be spread to almost the bottom of the page. what do you think?

@shaurya-harness In that case, I’d reduce the maximum number of characters allowed in the description. We could follow GitHub’s example. Here’s what it looks like when I fill in the repository description with the maximum number of characters:

Arc 2024-12-05 16 43 19

@shaurya-harness
Copy link
Contributor Author

we set a line-clamp-3 here as well, since max characters can be 1024, it would be spread to almost the bottom of the page. what do you think?

@shaurya-harness In that case, I’d reduce the maximum number of characters allowed in the description. We could follow GitHub’s example. Here’s what it looks like when I fill in the repository description with the maximum number of characters:

Arc 2024-12-05 16 43 19

okay, will need a backend change for this, I'll mention in our PIPE sync today

@shaurya-harness
Copy link
Contributor Author

@andrewgolovanov just had a word with @bradrydzewski , we can't reduce the max chars support at backend as some of our old customers might have long descriptions. we should be looking at truncating to a few lines, earlier it used to be line-clamp-3, we can change that to 8 maybe for parity with github?

@andrewgolovanov
Copy link
Collaborator

@andrewgolovanov just had a word with @bradrydzewski , we can't reduce the max chars support at backend as some of our old customers might have long descriptions. we should be looking at truncating to a few lines, earlier it used to be line-clamp-3, we can change that to 8 maybe for parity with github?

Alright, no problem. In that case, yes, we can limit it to 8 lines, like on GitHub. In the future, we could consider adding a Tooltip that appears when hovering over the description, allowing users to see the full text. But for now, that’s just a rough idea - I plan to discuss it with the design team soon.

@shaurya-harness
Copy link
Contributor Author

Copy link
Collaborator

@andrewgolovanov andrewgolovanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

@shaurya-harness shaurya-harness merged commit fec1cba into main Dec 9, 2024
10 checks passed
@shaurya-harness shaurya-harness deleted the repo-description branch December 9, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants