Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only get build ID if executable path is not supplied. #2801

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

AshIzat
Copy link
Contributor

@AshIzat AshIzat commented Oct 22, 2024

fixes #2800

@kblok
Copy link
Member

kblok commented Oct 22, 2024

Great catch @AshIzat!
Do you need a new version with this now? I can make it if you need it :)

@AshIzat
Copy link
Contributor Author

AshIzat commented Oct 22, 2024

Great catch @AshIzat! Do you need a new version with this now? I can make it if you need it :)

That would be incredibly useful actually, thanks.

@kblok
Copy link
Member

kblok commented Oct 22, 2024

Do you

Great catch @AshIzat! Do you need a new version with this now? I can make it if you need it :)

That would be incredibly useful actually, thanks.

Do you want to replace all the 20.0.2 to 20.0.3 in the PuppeteerSharp.csproj file?

@AshIzat
Copy link
Contributor Author

AshIzat commented Oct 22, 2024

Do you

Great catch @AshIzat! Do you need a new version with this now? I can make it if you need it :)

That would be incredibly useful actually, thanks.

Do you want to replace all the 20.0.2 to 20.0.3 in the PuppeteerSharp.csproj file?

Done.

@kblok kblok merged commit 924c71b into hardkoded:master Oct 22, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Puppeteer fails to launch chromium without internet access
2 participants