[BREAKING] Webdriver Bidi support #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eer-sharp into protocol-option
# Conflicts: # lib/PuppeteerSharp.Tests/LauncherTests/PuppeteerConnectTests.cs # lib/PuppeteerSharp.Tests/TestConstants.cs
kblok
force-pushed
the
protocol-using-webdriver-driver
branch
from
4744bf1 to
560ce2f
Compare
…river-driver # Conflicts: # lib/PuppeteerSharp.Tests/LauncherTests/BrowserCloseTests.cs # lib/PuppeteerSharp/States/DisposedState.cs # lib/PuppeteerSharp/States/ExitedState.cs # lib/PuppeteerSharp/States/ExitingState.cs # lib/PuppeteerSharp/States/KillingState.cs # lib/PuppeteerSharp/States/StartedState.cs # lib/PuppeteerSharp/States/State.cs
# Conflicts: # lib/PuppeteerSharp/BrowserContext.cs
jnyrup
reviewed
Oct 30, 2024
| @@ -43,6 +43,7 @@ | |||
| <PrivateAssets>all</PrivateAssets> | |||
| </PackageReference> | |||
| <PackageReference Include="Microsoft.Extensions.Logging" Version="8.0.0" /> | |||
| <PackageReference Include="WebDriverBiDi" Version="0.0.9" /> | |||
There was a problem hiding this comment.
Would be convenient if WebDriverBiDi had a .NET target without any nuget dependencies.
There was a problem hiding this comment.
FYI: WebDriverBiDi has a newer release with the added TFMs
There was a problem hiding this comment.
Yes. I'm working on a new PR that needs that version 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First green of a navigation test.
Breaking changes
ITarget.TargetIdwas removed.