add user agent tests

hardkoded · Dec 3, 2024 · c39891f · c39891f
1 parent ef7077b
commit c39891f
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 20 deletions.
diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml
@@ -11,6 +11,7 @@ on:
     paths:
     - '**.yml'
     - '**.cs'
+    - '**.json'
     - '**.csproj'
     - '**.runsettings'
 

diff --git a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json
@@ -135,21 +135,6 @@
       "FAIL"
     ]
   },
-  {
-    "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
-    "testIdPattern": "[browser.spec] *Browser.userAgent*",
-    "platforms": [
-      "darwin",
-      "linux",
-      "win32"
-    ],
-    "parameters": [
-      "webDriverBiDi"
-    ],
-    "expectations": [
-      "FAIL"
-    ]
-  },
   {
     "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
     "testIdPattern": "[navigation.spec] navigation Page.waitForNavigation*",

diff --git a/lib/PuppeteerSharp.Tests/BrowserTests/UserAgentTests.cs b/lib/PuppeteerSharp.Tests/BrowserTests/UserAgentTests.cs
@@ -6,10 +6,6 @@ namespace PuppeteerSharp.Tests.BrowserTests
 {
     public class UserAgentTests : PuppeteerBrowserBaseTest
     {
-        public UserAgentTests() : base()
-        {
-        }
-
         [Test, Retry(2), PuppeteerTest("browser.spec", "Browser.userAgent", "should include WebKit")]
         public async Task ShouldIncludeWebKit()
         {

diff --git a/lib/PuppeteerSharp/Bidi/BidiBrowser.cs b/lib/PuppeteerSharp/Bidi/BidiBrowser.cs
@@ -89,7 +89,7 @@ private BidiBrowser(Core.Browser browserCore, LaunchOptions options, ILoggerFact
     public override Task<string> GetVersionAsync() => Task.FromResult($"{BrowserName}/{BrowserVersion}");
 
     /// <inheritdoc />
-    public override Task<string> GetUserAgentAsync() => throw new NotImplementedException();
+    public override Task<string> GetUserAgentAsync() => Task.FromResult(BrowserCore.Session.Info.Capabilities.UserAgent);
 
     /// <inheritdoc />
     public override void Disconnect() => throw new NotImplementedException();