Bidi: Browser.Process

hardkoded · Dec 4, 2024 · af23d0a · af23d0a
1 parent 8d9816d
commit af23d0a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json
@@ -107,7 +107,7 @@
   },
   {
     "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
-    "testIdPattern": "[browser.spec] *Browser.process*",
+    "testIdPattern": "[browser.spec] *should not return child_process for remote browser*",
     "platforms": [
       "darwin",
       "linux",

diff --git a/lib/PuppeteerSharp/Bidi/BidiBrowser.cs b/lib/PuppeteerSharp/Bidi/BidiBrowser.cs
@@ -142,7 +142,8 @@ public override async Task<IBrowserContext> CreateBrowserContextAsync(BrowserCon
     internal static async Task<BidiBrowser> CreateAsync(
         BiDiDriver driver,
         LaunchOptions options,
-        ILoggerFactory loggerFactory)
+        ILoggerFactory loggerFactory,
+        LauncherBase launcher)
     {
         var session = await Session.FromAsync(
             driver,
@@ -164,7 +165,7 @@ await session.SubscribeAsync(
                 ? SubscribeModules
                 : [.. SubscribeModules, .. SubscribeCdpEvents]).ConfigureAwait(false);
 
-        var browser = new BidiBrowser(session.Browser, options, loggerFactory);
+        var browser = new BidiBrowser(session.Browser, options, loggerFactory) { Launcher = launcher };
         browser.InitializeAsync();
         return browser;
     }

diff --git a/lib/PuppeteerSharp/Launcher.cs b/lib/PuppeteerSharp/Launcher.cs
@@ -94,7 +94,7 @@ public async Task<IBrowser> LaunchAsync(LaunchOptions options)
                     {
                         var driver = new BiDiDriver(TimeSpan.FromMilliseconds(options.ProtocolTimeout));
                         await driver.StartAsync(Process.EndPoint + "/session").ConfigureAwait(false);
-                        browser = await BidiBrowser.CreateAsync(driver, options, _loggerFactory).ConfigureAwait(false);
+                        browser = await BidiBrowser.CreateAsync(driver, options, _loggerFactory, Process).ConfigureAwait(false);
                     }
                     else
                     {