Set response.status in bidi (#2817)

* Set Response.Status in bidi * exclude falky test
hardkoded · Nov 4, 2024 · 42e30df · 42e30df
1 parent 53abf4d
commit 42e30df
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 15 deletions.
diff --git a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json
@@ -76,6 +76,13 @@
     "parameters": ["chrome"],
     "expectations": ["FAIL"]
   },
+  {
+    "comment": "This is flaky on CI/CD",
+    "testIdPattern": "[worker.spec] Workers Page.workers",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["chrome"],
+    "expectations": ["FAIL"]
+  },
   {
     "comment": "",
     "testIdPattern": "[puppeteer-sharp] *",
@@ -338,21 +345,6 @@
       "FAIL"
     ]
   },
-  {
-    "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
-    "testIdPattern": "[navigation.spec] *should navigate to empty page with domcontentloaded*",
-    "platforms": [
-      "darwin",
-      "linux",
-      "win32"
-    ],
-    "parameters": [
-      "webDriverBiDi"
-    ],
-    "expectations": [
-      "FAIL"
-    ]
-  },
   {
     "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
     "testIdPattern": "[navigation.spec] *should not throw an error for a 500 response with an empty body*",

diff --git a/lib/PuppeteerSharp/Bidi/BidiHttpResponse.cs b/lib/PuppeteerSharp/Bidi/BidiHttpResponse.cs
@@ -20,6 +20,7 @@
 //  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 //  * SOFTWARE.
 
+using System.Net;
 using System.Threading.Tasks;
 
 namespace PuppeteerSharp.Bidi;
@@ -34,6 +35,7 @@ private BidiHttpResponse(WebDriverBiDi.Network.ResponseData data, BidiHttpReques
     {
         _data = data;
         _request = request;
+        Status = (HttpStatusCode)data.Status;
     }
 
     /// <inheritdoc />