Fix transfer handle

hardkoded · Nov 15, 2023 · 404c92b · 404c92b
1 parent 88b45a0
commit 404c92b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/lib/PuppeteerSharp/IsolatedWorld.cs b/lib/PuppeteerSharp/IsolatedWorld.cs
@@ -114,6 +114,11 @@ internal override async Task<IJSHandle> TransferHandleAsync(IJSHandle handle)
                 return handle;
             }
 
+            if (handle.RemoteObject.ObjectId == null)
+            {
+                return handle;
+            }
+
             var info = await Client.SendAsync<DomDescribeNodeResponse>(
                 "DOM.describeNode",
                 new DomDescribeNodeRequest

diff --git a/lib/PuppeteerSharp/JSHandle.cs b/lib/PuppeteerSharp/JSHandle.cs
@@ -46,11 +46,12 @@ internal JSHandle(IsolatedWorld world, RemoteObject remoteObject)
 
         /// <inheritdoc/>
         public Task<IJSHandle> GetPropertyAsync(string propertyName)
-            => EvaluateFunctionHandleAsync(
-                @"(object, propertyName) => {
-                    return object[propertyName];
-                }",
-                propertyName);
+            => BindIsolatedHandleAsync(handle =>
+                handle.EvaluateFunctionHandleAsync(
+                    @"(object, propertyName) => {
+                        return object[propertyName];
+                    }",
+                    propertyName));
 
         /// <inheritdoc/>
         public Task<Dictionary<string, IJSHandle>> GetPropertiesAsync()