Close page on disposal (#2720)

hardkoded · Aug 8, 2024 · 2d44dc7 · 2d44dc7
1 parent c4c67db
commit 2d44dc7
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/lib/PuppeteerSharp/Page.cs b/lib/PuppeteerSharp/Page.cs
@@ -752,12 +752,6 @@ public async ValueTask DisposeAsync()
         {
             try
             {
-                // We don't want to close the page if we're connected to the browser using `Connect`.
-                if (Browser.Launcher == null)
-                {
-                    return;
-                }
-
                 await CloseAsync().ConfigureAwait(false);
             }
             catch

diff --git a/lib/PuppeteerSharp/PuppeteerSharp.csproj b/lib/PuppeteerSharp/PuppeteerSharp.csproj
@@ -12,7 +12,7 @@
     <Description>Headless Browser .NET API</Description>
     <PackageId>PuppeteerSharp</PackageId>
     <PackageReleaseNotes></PackageReleaseNotes>
-    <PackageVersion>18.1.0-beta1</PackageVersion>
+    <PackageVersion>18.1.0</PackageVersion>
     <ReleaseVersion>18.1.0</ReleaseVersion>
     <AssemblyVersion>18.1.0</AssemblyVersion>
     <FileVersion>18.1.0</FileVersion>
-Original file line number
+Diff line change
@@ Expand Up / @@ -752,12 +752,6 @@ public async ValueTask DisposeAsync() @@
             {
                 try
                 {
-                    // We don't want to close the page if we're connected to the browser using `Connect`.
-                    if (Browser.Launcher == null)
-                    {
-                        return;
-                    }
                     await CloseAsync().ConfigureAwait(false);
                 }
                 catch
@@ Expand Down @@